Rasmus Dahlberg (82f98ac8) at 26 Mar 12:57
Add meeting minutes
Rasmus Dahlberg (29adc622) at 20 Mar 09:10
Add meeting minutes
Niels Möller (284c3719) at 19 Mar 09:37
Niels Möller (f386af64) at 19 Mar 09:37
Merge branch 'nisse/date-byzantine-witnesses' into 'main'
... and 1 more commit
Niels Möller (284c3719) at 19 Mar 08:38
Add date of previous edit to the byzantine-witnesses .tex and .pdf ...
Filippo Valsorda (d5b31b13) at 19 Mar 06:59
This is much more convenient to read in the web UI as a PDF.
Niels Möller (bfd835d2) at 19 Mar 06:59
Merge branch 'filippo/byzantinepdf' into 'main'
... and 1 more commit
Filippo Valsorda (69958133) at 18 Mar 17:43
This MR focuses on bringing witness.md up to speed with the proposals, while keeping the structure and voice of the current spec.
When moving this to C2SP, I'll do a pass to match the voice of the other tlog specs, and remove the redundant cosignature definition.
Rasmus Dahlberg (a42c47b8) at 18 Mar 17:43
Merge branch 'filippo/witness.md' into 'main'
... and 3 more commits
Great thanks, merging !
This should be ready to merge!
Good catch about size limits. Limited the number of hashes to 63, and filed https://github.com/C2SP/C2SP/issues/62 to track adding a limit for checkpoints. I think 2^63 - 1 is a good cap, the Go tlog package also expresses indexes as int64.
I think we should support multiple checkpoint signatures, to enable log signing key rotation. The log might not know if the witness updated its public key yet. Relaxed the singular log signature language in the spec, thank you!
I also prefer not to make applications split unsigned checkpoint and signature while parsing. With the current layout the application does simple line-based parsing up to the empty line, then passes the rest of the body to note.Open (or equivalent) without having to parse.
Ah yes sorry 32 bits / uint32. The specs and libraries have this right, I just typed it wrong in my comment.
Filippo Valsorda (69958133) at 18 Mar 17:10
witness: address review comment
Reassigned since I don't have the merge bit!